GUI crashing info

Jackson · November 30, 2022, 1:44pm

Hey, @nathan in Maryland I remember you telling me to let you know about the GUI crashing. I have narrowed it down to something to do with the sandbox. While messing around with the sandbox after the event, I noticed that it crashed whenever the sandbox was being used. This became very obvious when I was experimenting with infinite loops in the sandbox which caused the GUI to 100% crash. Our sandbox at the competition was not an infinite loop, but it was still pretty complex, making it crash only some of the time. This is not an issue right now, as I totally revamped our code to be more optimized and it doesn’t cause any crashes. Just thought I would let you know.

nathan · November 30, 2022, 3:40pm

What was this infinite loop doing? The GUI only talks to the drone over MQTT so I can only imagine you somehow publishing a message that broke it. If you send me a GitHub link, I can take a look tonight.

Jackson · November 30, 2022, 6:33pm

I’ll send you a GitHub link but it will be a bunch of commits old since we swapped to a different system. Could it be the fact that it was sending 4-5 logging messages every two seconds?

nathan · November 30, 2022, 6:35pm

You can view old commits in the GitHub UI, that’s fine. If you look at your commit history and can identify what commit this was occuring at, that will help a lot.

It should be fine, the normal flight software sends something like 100 MQTT messages per second, and anecdotally, the GUI can handle over 1000 per second without breaking a sweat.

Jackson · November 30, 2022, 6:37pm

Here is the commit that shows it the best. Whenever autonomous enable is pressed, the GUI slows down, starts dropping messages, and crashes. It usually takes anywhere from 5-30 seconds to happen.

github.com

bellflight/AVR-2022/blob/fb776ba7e5b6ebdbd36b273ca8ac134270e7755d/VMC/sandbox/sandbox.py

# Here we import our own MQTT library which takes care of a lot of boilerplate
# code related to connecting to the MQTT server and sending/receiving messages.
# It also helps us make sure that our code is sending the proper payload on a topic
# and is receiving the proper payload as well.
#from typing_extensions import Self
from ast import Not
from bell.avr.mqtt.client import MQTTModule
from bell.avr.mqtt.payloads import (
    AvrApriltagsVisiblePayload,
    AvrAutonomousEnablePayload,
    AvrAutonomousBuildingDropPayload,
)
from loguru import logger
import time

class Sandbox(MQTTModule):

    # NOTE needs logic to handle multiple drops per auto
    def __init__(self):
        super().__init__()

This file has been truncated. show original

nathan · November 30, 2022, 6:38pm

Thanks. I’ll take a look

Jackson · November 30, 2022, 6:42pm

Here is our most recent commit. While running this code, I haven’t had the GUI crash at all. Thanks!

github.com

BHS-drone-team/AVR-2022/blob/main/VMC/sandbox/sandbox.py

# Here we import our own MQTT library which takes care of a lot of boilerplate
# code related to connecting to the MQTT server and sending/receiving messages.
# It also helps us make sure that our code is sending the proper payload on a topic
# and is receiving the proper payload as well.
#from typing_extensions import Self
from ast import Not
from bell.avr.mqtt.client import MQTTModule
from bell.avr.mqtt.payloads import (
    AvrApriltagsVisiblePayload,
    AvrAutonomousEnablePayload,
    AvrAutonomousBuildingDropPayload,
)
from loguru import logger
import time

class Sandbox(MQTTModule):

    # NOTE needs logic to handle multiple drops per auto
    def __init__(self):
        super().__init__()

This file has been truncated. show original

nathan · November 30, 2022, 10:50pm

I tried commit fb776ba7e5b6ebdbd36b273ca8ac134270e7755d and it would not start.

avr-2022-sandbox-1  |   File "/app/sandbox.py", line 53
avr-2022-sandbox-1  |     global has_dropped_0
avr-2022-sandbox-1  |     ^
avr-2022-sandbox-1  | SyntaxError: name 'has_dropped_0' is used prior to global declaration

I was able to run commit 3d1a4f14b39400c29fd47fdd25794ae6a1119878 instead, but I wasn’t able to replicate any issues.

I stepped forward until I got commit 74cc02a784f6b83703a5d5be277a6c4ff9a9cafd to run, but again, I was unable to replicate any issues.

If you’re able to figure out how to crash the GUI again and post the output like the following, that would help:

Unrelated items:

I would strongly avoid using global variables. For what you’re doing, replacing these with class attributes like self.all_dropped will be far simpler and less confusing.
I think you can get rid of your

while time.time () < finish_1:
    pass

loops at this point and replace them with time.sleep. If you want me to provide more code suggestions, I can do a more thorough review.
3. Your commit messages remind me of this.

Topic		Replies	Views
Autonomous Questions AVR Drone Software	5	469	May 24, 2023
Sandbox Typing Module Errors AVR Drone Software	3	378	October 12, 2022
AVR Drone GUI - Missing Data (Telemetry+Thermal) AVR Drone Software	7	251	September 11, 2023
Can't connect to VRC GUI Technical Support (Official)	11	610	November 2, 2022
Avr/autonomous/enable problems AVR Drone Software	2	272	October 27, 2022

GUI crashing info

Related topics